-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDN-4923: Bump to k8s v1.30 latest #2429
Conversation
@jcaamano: This pull request references SDN-4916 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
67dffeb
to
ec1afc1
Compare
/retest |
@@ -43,7 +44,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler) error { | |||
} | |||
|
|||
// Watch for changes to primary resource config.openshift.io/v1/Network | |||
err = c.Watch(source.Kind(mgr.GetCache(), &configv1.Network{}), &handler.EnqueueRequestForObject{}, predicate.GenerationChangedPredicate{}) | |||
err = c.Watch(source.Kind[client.Object](mgr.GetCache(), &configv1.Network{}, &handler.EnqueueRequestForObject{}, predicate.GenerationChangedPredicate{})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other files can we use a crclient
alias for sigs.k8s.io/controller-runtime/pkg/client
?
/lgtm |
go get k8s.io/api@v0.30.2 go get k8s.io/code-generator@v0.30.2 go get k8s.io/component-base@v0.30.2 go get k8s.io/kube-proxy@v0.30.2 go get k8s.io/apiextensions-apiserver@v0.30.2 go get github.com/openshift/build-machinery-go go get github.com/openshift/api go get github.com/openshift/client-go go get github.com/openshift/library-go go get github.com/openshift/machine-config-operator go get k8s.io/kube-aggregator@v0.30.2 go get sigs.k8s.io/apiserver-network-proxy/konnectivity-client@v0.30.3 go get k8s.io/utils go get sigs.k8s.io/controller-runtime@v0.18.4 go mod vendor go mod tidy Fix API changes Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, kyrtapz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jcaamano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
e3fd660
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-network-operator-container-v4.17.0-202407051811.p0.ge3fd660.assembly.stream.el9 for distgit cluster-network-operator. |
/retitle SDN-4923: Bump to k8s v1.30 latest |
Refer to commit messages for detailed steps taken.
Replaces: #2423